Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7c1615782
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const reviewQuery = { | ||
| building_name: building.review_name, | ||
| room_no: room.room_no, |
There was a problem hiding this comment.
Preserve the stored building casing for review lookups
For reviews submitted under the room/UI spelling (for example, Blair), this sends BLAIR because the generated catalog sets review_name using key(name). The existing /get_reviews route compares Reviews.building_name with exact equality (routes.py:88-92), while /submitReview persists the incoming titlecase building name unchanged (routes.py:796-807,856-858). The endpoint therefore returns valid no-review markup, and MCP reports available: true with an empty review list even when the live room record has a nonzero num_reviews; use the stored spelling or retry the titlecase form rather than unconditionally uppercasing it.
Useful? React with 👍 / 👎.
| let pending = this.inFlight.get(url); | ||
| if (!pending) { | ||
| pending = this.request(url, route === "/get_reviews", deadline); | ||
| this.inFlight.set(url, pending); |
There was a problem hiding this comment.
Let later callers use their own request deadline
When an identical URL is first requested by a caller with little time remaining—such as a campus search nearing its deadline—and then by a fresh tool call, the second caller reuses a request whose abort timeout and retry loop were fixed to the first caller's deadline. That shared request can abort almost immediately, making the fresh call fail or use static fallback despite having nearly ten seconds left; after a shared request constrained by another caller fails, retry it using the current caller's deadline or avoid baking the initiating caller's deadline into the coalesced transport.
Useful? React with 👍 / 👎.
Summary
Add a standalone, read-only MCP service exposing six tools for buildings, room search/details, images, reviews, and floor plans. Current room data comes from TigerDraw public APIs, with normalized static fallback, duplicate source IDs, explicit field conflicts, bounded results, and untrusted review handling.
TigerDraw owns PDF originals and verified first-page previews. Catalog generation validates PDF/PNG hashes. Public static previews require no runtime rendering or database access.
Validation
Deployment
Deploy the MCP service and static preview assets on TigerDraw before enabling PI. Configure the systemd service and nginx /mcp route; set MCP_ACCESS_TOKEN to match PI's TIGERDRAW_MCP_TOKEN. No database credentials are required. Poppler is needed only for regenerating previews.
Companion PI PR: TigerAppsOrg/pi#51
Screenshots